-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[rb] Remove prism
dependency
#16437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb] Remove prism
dependency
#16437
Conversation
This project does not use prism at all. At most it is being used by rubocop during local development. It was added in SeleniumHQ#16357 but it is unclear to me why. I just bumped it for this repo, perhaps that JRuby issue has since been fixed. Either way, it should not be part of the gemspec.
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
PR Code Suggestions ✨Explore these optional code suggestions:
|
If there is something broken with prism on jruby, please let me know. I am a contributor to |
I think there was a conflict with Rubocop. Let's run the CI and see if it fails again. |
It fails to build with the following error: src/prism.c: In function ‘context_terminator’: src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion] 8651 | return token->type < 32 && (context_terminators[context] & (1 << token->type)); | ^ cc1: all warnings being treated as errors
Ok, I see the error. It's a build failure that I don't think is related to JRuby at all. I have pinned back to 1.4.0 in the Gemfile to allow the build to pass. Specifying it there allows consumers of I will see about getting that warning fixed in prism so that it can be unpinned here. Unsure why it fails your build here, I guess some compiler option that ruby itself doesn't test against. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
The build failure may be fixed in the next prism release: ruby/prism#3682 |
User description
This project does not use prism at all. At most it is being used by rubocop during local development.
It was added in #16357 but it is unclear to me why. I just bumped it for this repo, perhaps that JRuby issue has since been fixed. Either way, it should not be part of the gemspec.
🔗 Related Issues
Added in #16357
💥 What does this PR do?
Remove prism as a dependency and bump it.
🔧 Implementation Notes
selenium-webdriver does not use prism at all
🔄 Types of changes
PR Type
Bug fix
Description
Remove unused
prism
dependency from gemspecBump
prism
version in MODULE.bazel to 1.5.2Clean up unnecessary runtime dependency
Diagram Walkthrough
File Walkthrough
selenium-webdriver.gemspec
Remove prism dependency from gemspec
rb/selenium-webdriver.gemspec
prism
dependency from gemspec dependencies listMODULE.bazel
Bump prism version to 1.5.2
MODULE.bazel
prism
version from 1.4.0 to 1.5.2