Skip to content

[rb] Remove prism dependency #16437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2025
+5 −2
Merged

[rb] Remove prism dependency #16437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c44f90e
[rb] Remove `prism` dependency
Earlopain Oct 15, 2025
dee4ce8
Merge branch 'trunk' into rb-remove-prism-dep
diemol Oct 15, 2025
3e3b2f1
Pin prism to 1.4.0 for the project
Earlopain Oct 15, 2025
04bb2ce
Merge branch 'trunk' into rb-remove-prism-dep
diemol Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rb/Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ gem 'activesupport', '~> 7.0', require: false, platforms: %i[mri mingw x64_mingw
gem 'curb', '~> 1.0.5', require: false, platforms: %i[mri mingw x64_mingw]
gem 'debug', '~> 1.7', require: false, platforms: %i[mri mingw x64_mingw]
gem 'steep', '~> 1.5.0', require: false, platforms: %i[mri mingw x64_mingw]

# Prism staring with 1.5 fails to build with the following error:
# src/prism.c:8651:62: error: conversion to ‘unsigned int’ from ‘int’ may change the sign of the result [-Werror=sign-conversion]
gem 'prism', ['~> 1.0', '< 1.5']
2 changes: 1 addition & 1 deletion rb/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ PATH
base64 (~> 0.2)
json (<= 2.13.2)
logger (~> 1.4)
prism (~> 1.0, < 1.5)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 4.0)
websocket (~> 1.0)
Expand Down Expand Up @@ -201,6 +200,7 @@ DEPENDENCIES
curb (~> 1.0.5)
debug (~> 1.7)
git (~> 1.19)
prism (~> 1.0, < 1.5)
rack (~> 2.0)
rake (~> 13.0)
rspec (~> 3.0)
Expand Down
1 change: 0 additions & 1 deletion rb/selenium-webdriver.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ Gem::Specification.new do |s|
s.add_dependency 'base64', ['~> 0.2']
s.add_dependency 'json', ['<= 2.13.2']
s.add_dependency 'logger', ['~> 1.4']
s.add_dependency 'prism', ['~> 1.0', '< 1.5']
s.add_dependency 'rexml', ['~> 3.2', '>= 3.2.5']
s.add_dependency 'rubyzip', ['>= 1.2.2', '< 4.0']
s.add_dependency 'websocket', ['~> 1.0']
Expand Down