Update word cloud for D3 v6 #978
Closed
maxnth wants to merge 2 commits intoSemanticMediaWiki:masterfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
=========================================
Coverage 46.24% 46.24%
Complexity 2361 2361
=========================================
Files 80 80
Lines 8957 8957
=========================================
Hits 4142 4142
Misses 4815 4815 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Word clouds didn’t work for me with the latest version of SRF (which uses D3 v6.7.0) as some of the syntax and the D3 layout.cloud library included in the build were deprecated in recent D3 versions.
Replacing the deprecated 20-color category scale with a manually defined ordinal scale (not the original color scale but should be 20 distinctive and readable colors) and updating the old library to the latest version from GitHub fixed the issue for me.
Edit: If preferred one could also manually add back the "old" colours which were part of
category20b: