Fix VectorStore lifecycle management and remove premature disposal #162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code analysis warning about undisposed InMemoryVectorStore instances while fixing an incorrect disposal pattern that would break returned collections.
Changes
usingdisposal of RedisVectorStore - The collection requires the store to remain alive; disposing immediately causes runtime failuresContext
The VectorStoreCollection depends on the VectorStore instance - proper lifecycle management requires either DI or caller-managed disposal.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.