Developer microsoft memory kernel #160

JeffreySu · 2025-11-01T03:12:15Z

No description provided.

Optimize the VectorDB class in the Senparc.AI.Interfaces class Debug Embedding Function Content

Optimize Problem

…Senparc/Senaprc.AI into Developer-MicrosoftMemoryKernel

[2025-11-01] v0.24.4 Combine VectorDBType from different projects

Copilot

Pull Request Overview

This PR consolidates VectorDB type enumerations from different projects into a single unified definition. The main purpose is to simplify the codebase by combining VectorDBType enumerations and updating the vector store configuration logic to use the consolidated enum.

Key changes:

Replaced the extensive VectorDBType enum (with 19 values) with a simplified enum containing 9 basic types (Memory, HardDisk, Redis, Mulivs, Chroma, PostgreSQL, Sqlite, SqlServer, Qdrant)
Updated switch-case statements in KernelConfigExtensions to map to the new enum values
Removed redundant code and unused SenparcSetting parameter from sample application

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
Senparc.AI.csproj	Updated version to 0.24.4 and added release note for VectorDBType consolidation
ISenparcAiSetting.cs	Replaced the complex VectorDBType enum (19 values) with a simplified version (9 values), commented out the old enum
Enums.cs	Commented out the duplicate VectorDBType enum definition
Senparc.AI.Kernel.csproj	Updated version to 0.25.3
KernelConfigExtensions.cs	Refactored switch statements to use new VectorDBType values, added using statement for VectorDB
Senparc.AI.Agents.csproj	Updated version to 0.5.7
Program.cs	Removed unused SenparcSetting initialization and parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/Senparc.AI/Interfaces/ISenparcAiSetting.cs

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

Copilot · 2025-11-01T03:15:57Z

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

-                case VectorDB.VectorDBType.CosmosDBMongoDB:
+                case VectorDBType.Memory:
                    {
+                        vectorStore = new InMemoryVectorStore();


Disposable 'InMemoryVectorStore' is created but not disposed.

@copilot open a new pull request to apply changes based on this feedback

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

…sions.cs Co-authored-by: Copilot <[email protected]>

Co-authored-by: Copilot <[email protected]>

…sions.cs Co-authored-by: Copilot <[email protected]>

Copilot · 2025-11-01T05:32:33Z

@JeffreySu I've opened a new pull request, #161, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-01T05:33:46Z

@JeffreySu I've opened a new pull request, #162, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2025-11-01T05:34:00Z

@JeffreySu I've opened a new pull request, #163, to work on those changes. Once the pull request is ready, I'll request review from you.

…sposal Co-authored-by: JeffreySu <[email protected]>

…ment Co-authored-by: JeffreySu <[email protected]>

Wrap disposable vector stores in using statements to prevent resource leaks

Fix VectorStore lifecycle management and remove premature disposal

Copilot · 2025-11-01T08:01:02Z

@JeffreySu I've opened a new pull request, #164, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: JeffreySu <[email protected]>

[WIP] Update based on feedback from PR #160

Copilot

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-01T08:12:39Z

src/Senparc.AI/Interfaces/ISenparcAiSetting.cs

+        //    JDBC=8,
+        //    Milvus=9,     //Planed (not included in https://learn.microsoft.com/en-us/semantic-kernel/concepts/vector-store-connectors/out-of-the-box-connectors/inmemory-connector?pivots=programming-language-csharp)
+        //    MongoDB=10,
+        //    Pinecon=11,


Possible typo: 'Pinecon' should likely be 'Pinecone' (the vector database name) in commented code.

Suggested change

// Pinecon=11,

// Pinecone=11,

Copilot · 2025-11-01T08:12:39Z

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

-                case VectorDB.VectorDBType.CosmosDBMongoDB:
+                case VectorDBType.Memory:
                    {
+                        vectorStore = new InMemoryVectorStore();


Disposable 'InMemoryVectorStore' is created but not disposed.

Copilot · 2025-11-01T08:12:40Z

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

+                        vectorStore = new RedisVectorStore(database,
+                            new() { StorageType = RedisStorageType.Json });
+                        collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);


Disposable 'RedisVectorStore' is created but not disposed.

Suggested change

vectorStore = new RedisVectorStore(database,

new() { StorageType = RedisStorageType.Json });

collection = vectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);

using (var redisVectorStore = new RedisVectorStore(database,

new() { StorageType = RedisStorageType.Json }))

{

collection = redisVectorStore.GetCollection<TKey, TRecord>(name, vectorStoreRecordDefinition);

}

src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExtensions.cs

zhao365845726 and others added 6 commits October 10, 2025 21:07

Optimize Problem

4a9d864

Optimize the VectorDB class in the Senparc.AI.Interfaces class Debug Embedding Function Content

Opitmize the VectorDBType define position.

80758e4

Merge pull request #159 from Senparc/Developer-MicrosoftMemoryKernel-zmz

d6b7679

Optimize Problem

Update Program.cs

c3f615e

Merge branch 'Developer-MicrosoftMemoryKernel' of https://github.com/…

2646df2

…Senparc/Senaprc.AI into Developer-MicrosoftMemoryKernel

chore: update project versions and add Qdrant support in VectorDBType

16a6493

[2025-11-01] v0.24.4 Combine VectorDBType from different projects

JeffreySu requested review from Copilot and zhao365845726 and removed request for Copilot November 1, 2025 03:12

Copilot AI reviewed Nov 1, 2025

View reviewed changes

JeffreySu and others added 7 commits November 1, 2025 11:21

Update src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExten…

d9b8829

…sions.cs Co-authored-by: Copilot <[email protected]>

Update src/Senparc.AI/Interfaces/ISenparcAiSetting.cs

5bcd0ed

Co-authored-by: Copilot <[email protected]>

Update src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExten…

bda2cbe

…sions.cs Co-authored-by: Copilot <[email protected]>

Update src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExten…

7c2f738

…sions.cs Co-authored-by: Copilot <[email protected]>

Update src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExten…

3649a93

…sions.cs Co-authored-by: Copilot <[email protected]>

Update src/Senparc.AI.Kernel/KernelConfigExtensions/KernelConfigExten…

bb6eda4

…sions.cs Co-authored-by: Copilot <[email protected]>

Initial plan

3e52f9b

Copilot AI mentioned this pull request Nov 1, 2025

Wrap disposable vector stores in using statements to prevent resource leaks #161

Merged

Initial plan

4b5277c

This was referenced Nov 1, 2025

Fix VectorStore lifecycle management and remove premature disposal #162

Merged

Fix vector store disposal by retrieving from DI container #163

Closed

Copilot AI and others added 5 commits November 1, 2025 05:38

Wrap disposable vector stores in using statements to ensure proper di…

ccc71b2

…sposal Co-authored-by: JeffreySu <[email protected]>

Fix VectorStore lifecycle management and remove incorrect using state…

71f9006

…ment Co-authored-by: JeffreySu <[email protected]>

Merge pull request #161 from Senparc/copilot/sub-pr-160

9dbc492

Wrap disposable vector stores in using statements to prevent resource leaks

Merge pull request #162 from Senparc/copilot/sub-pr-160-again

b0fd111

Fix VectorStore lifecycle management and remove premature disposal

Initial plan

e217720

Copilot AI mentioned this pull request Nov 1, 2025

[WIP] Update based on feedback from PR #160 #164

Merged

6 tasks

Copilot AI and others added 2 commits November 1, 2025 08:04

Fix VectorStore disposal issue by removing incorrect using statements

2306ad6

Co-authored-by: JeffreySu <[email protected]>

Merge pull request #164 from Senparc/copilot/sub-pr-160-yet-again

7edd730

[WIP] Update based on feedback from PR #160

JeffreySu requested a review from Copilot November 1, 2025 08:09

Copilot AI reviewed Nov 1, 2025

View reviewed changes

JeffreySu merged commit c16e244 into main Nov 1, 2025
7 checks passed

Developer microsoft memory kernel #160

Developer microsoft memory kernel #160

Uh oh!

Conversation

JeffreySu commented Nov 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

JeffreySu Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

JeffreySu Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Nov 1, 2025

Uh oh!

Copilot AI commented Nov 1, 2025

Uh oh!

Copilot AI commented Nov 1, 2025

Uh oh!

Copilot AI commented Nov 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants