Skip to content

[WIP] Update based on feedback from PR #160 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JeffreySu merged 2 commits into from
Nov 1, 2025
Merged

[WIP] Update based on feedback from PR #160 #164

JeffreySu merged 2 commits into from
Nov 1, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 1, 2025 •
edited
Loading

  • Analyze the VectorStore disposal issue in GetVectorCollection method
  • Remove incorrect using statements for InMemoryVectorStore instances
  • Remove incorrect using statement for QdrantVectorStore instance
  • Re-add vectorStore variable declaration
  • Verify the changes align with the existing documentation comment
  • Build the project successfully

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI mentioned this pull request Nov 1, 2025
Merged
@JeffreySu JeffreySu marked this pull request as ready for review November 1, 2025 08:08
@JeffreySu JeffreySu merged commit 7edd730 into Developer-MicrosoftMemoryKernel Nov 1, 2025
1 check was pending
Copilot AI requested a review from JeffreySu November 1, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffreySu JeffreySu Awaiting requested review from JeffreySu

Assignees

@JeffreySu JeffreySu

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JeffreySu