LibGUI: Remove spaces from DynamicWidgetContainer config key#26222
Merged
spholz merged 1 commit intoSerenityOS:masterfrom Oct 2, 2025
Merged
LibGUI: Remove spaces from DynamicWidgetContainer config key#26222spholz merged 1 commit intoSerenityOS:masterfrom
spholz merged 1 commit intoSerenityOS:masterfrom
Conversation
github-actions
bot
added
the
👀 pr-needs-review
The section_label prop is used as config key. But sometimes it contains spaces. Spaces in config keys are quite ugly and not following the .ini spec I think, so this commit filters them out.
bplaat
force-pushed
the
dynamic-widget-fix
branch
from
8a1bf33 to
caab8aa
Compare
github-actions
bot
removed
the
👀 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The section_label prop is used as config key. But sometimes it contains spaces. Spaces in config keys are quite ugly and not following the .ini spec I think, so this commit filters them out.
Commit split of from #26170