Fix instance consistency in KnowledgeBaseSearchTask #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves issue #119 where KnowledgeBaseSearchTask could use different ServiceNow instances within the same task when checking knowledge base integrity. Changed line 84 to use self.instance instead of creating a new SNowInstance(), ensuring the same instance is used throughout the task lifecycle. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #119 - Ensures that
KnowledgeBaseSearchTaskconsistently uses the same ServiceNow instance throughout its lifecycle instead of potentially creating a different instance during knowledge base validation.Changes
src/browsergym/workarena/tasks/knowledge.py:84to useself.instanceinstead of creating a newSNowInstance()Problem
After migrating to a common instances pool, the
check_knowledge_basecall inKnowledgeBaseSearchTask.__init__was creating a newSNowInstance()each time. SinceSNowInstance()now randomly selects from a pool of instances, this could result in the knowledge base check running on a completely different instance than the one the task was initialized with.Solution
Use
self.instance(inherited fromAbstractServiceNowTask) which is already set to the instance passed to the constructor or a default instance. This ensures consistency throughout the task execution.Testing
Ran the task across all 8 instances in the pool with 8 parallel workers:
Results: All 8 runs succeeded (8 success / 0 failed)
🤖 Generated with Claude Code