Conversation
tjoyal
force-pushed
the
fold-functions-pickup-point-delivery-option-generators-js-and-ts-impl
branch
2 times, most recently
from
c40847f to
b800212
Compare
adampetro
reviewed
Jul 4, 2025
tjoyal
force-pushed
the
fold-functions-pickup-point-delivery-option-generators-js-and-ts-impl
branch
from
b800212 to
3e7281b
Compare
adampetro
approved these changes
Jul 7, 2025
tjoyal
deleted the
fold-functions-pickup-point-delivery-option-generators-js-and-ts-impl
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
As far as I can tell the
-tspath suffix was an anomaly that was not getting properly consumed by paths assuming "typescript" would use-ts.Solution
Fold both examples for "typescript" and "vanilla-js" under the same
-jssuffix as it is done for every other templates.Checklist