Skip to content

add decoding for url-encoded paths#3436

Merged
itsjustriley merged 2 commits intomainfrom
resiliency-backlog-759
Feb 3, 2026
Merged

add decoding for url-encoded paths#3436
itsjustriley merged 2 commits intomainfrom
resiliency-backlog-759

Conversation

@itsjustriley
Copy link
Contributor

@itsjustriley itsjustriley commented Feb 3, 2026

WHY are these changes introduced?

Fixes shop/issues/issues/759

Resiliency backlog issue with error related to file path encoding

WHAT is this pull request doing?

Add decoding for url-encoded file paths, so spaces/special characters don't disrupt virtual routes

  • Added test
  • Added changeset

@shopify
Copy link
Contributor

shopify bot commented Feb 3, 2026

Oxygen deployed a preview of your resiliency-backlog-759 branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment February 3, 2026 3:28 PM

Learn more about Hydrogen's GitHub integration.

@itsjustriley itsjustriley marked this pull request as ready for review February 3, 2026 13:09
@itsjustriley itsjustriley requested a review from a team as a code owner February 3, 2026 13:09
@itsjustriley itsjustriley force-pushed the resiliency-backlog-759 branch from efbd870 to ed51909 Compare February 3, 2026 15:17
Copy link
Contributor

@fredericoo fredericoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! sorry for the nitpicks but this is now the cream of the crop

@itsjustriley itsjustriley merged commit d62c387 into main Feb 3, 2026
14 of 15 checks passed
@itsjustriley itsjustriley deleted the resiliency-backlog-759 branch February 3, 2026 17:36
This was referenced Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants