Merged
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
reviewed
Feb 3, 2026
fredericoo
reviewed
Feb 3, 2026
fredericoo
reviewed
Feb 3, 2026
efbd870 to
ed51909
Compare
fredericoo
approved these changes
Feb 3, 2026
Contributor
fredericoo
left a comment
There was a problem hiding this comment.
awesome! sorry for the nitpicks but this is now the cream of the crop
This was referenced Feb 3, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes shop/issues/issues/759
Resiliency backlog issue with error related to file path encoding
WHAT is this pull request doing?
Add decoding for url-encoded file paths, so spaces/special characters don't disrupt virtual routes