[Minor] Add App Bridge script to allow for strict CSP policy#1997
Merged
[Minor] Add App Bridge script to allow for strict CSP policy#1997
Conversation
byrichardpowell
approved these changes
Sep 18, 2025
byrichardpowell
approved these changes
Sep 18, 2025
fresh-eggs
approved these changes
Sep 23, 2025
4 tasks
lizkenyon
added a commit
that referenced
this pull request
Oct 22, 2025
Prevents breaking changes from PR #1997 which would force script-src on all apps Apps using default template (CSP disabled) must continue working without changes. Only apps explicitly enabling strict CSP should need App Bridge configuration. Breaking change avoided: PR #1997 automatically added script-src 'self' to all apps, blocking inline scripts including Vite HMR in development. This reverts to opt-in. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lizkenyon
added a commit
that referenced
this pull request
Oct 22, 2025
Prevents breaking changes from PR #1997 which would force script-src on all apps Apps using default template (CSP disabled) must continue working without changes. Only apps explicitly enabling strict CSP should need App Bridge configuration. Breaking change avoided: PR #1997 automatically added script-src 'self' to all apps, blocking inline scripts including Vite HMR in development. This reverts to opt-in. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
lizkenyon
added a commit
that referenced
this pull request
Oct 22, 2025
Prevents breaking changes from PR #1997 which would force script-src on all apps Apps using default template (CSP disabled) must continue working without changes. Only apps explicitly enabling strict CSP should need App Bridge configuration. Breaking change avoided: PR #1997 automatically added script-src 'self' to all apps, blocking inline scripts including Vite HMR in development. This reverts to opt-in. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This gem requires an asset that is hosted on cdn.shopify.com:
https://cdn.shopify.com/shopifycloud/app-bridge.jsFor applications that enforce a strict ContentSecurityPolicy, the asset is unlikely to be listed as a permitted script-src .
This PR modifies the
FrameAncestorsconcern to allow loading of the the App Bridge script. This concern is included in theEmbeddedAppconcern.Any time the app attempts to load in an embedded context it will allow the loading of App Bridge
test-ruby-csp-1080.mov
Reviewer's guide to testing
To test:
e.g.
Things to focus on
Checklist
Before submitting the PR, please consider if any of the following are needed:
CHANGELOG.mdif the changes would impact usersREADME.md, if appropriate./docs, if necessary