Skip to content

Fix MatchingTranslations check for Accounts translations #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamespeilow wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MatchingTranslations check for Accounts translations #931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6e51b3
Add tests
jpeilow-function May 2, 2025
8665241
Updated Theme Check MissingTranslations to ignore customer_accounts. …
jpeilow-function May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/theme-check-common/src/checks/matching-translations/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,36 @@ describe('Module: MatchingTranslations', async () => {
}
});

it('should not report offenses and ignore Shopify keys for Accounts (New)', async () => {
for (const prefix of ['', '.schema']) {
const theme = {
[`locales/en.default${prefix}.json`]: JSON.stringify({
hello: 'Hello',
customer_accounts: {
account_information: {
title: 'Account',
}
}
}),
[`locales/pt-BR${prefix}.json`]: JSON.stringify({
hello: 'Olá',
customer_accounts: {
navigation_and_structure: {
account_menu: {
label: 'Compte',
}
}
}
}),
};

const offenses = await check(theme, [MatchingTranslations]);
console.log(offenses);

expect(offenses).to.be.of.length(0);
}
});

it('should not report offenses and ignore "*.schema.json" files', async () => {
const theme = {
'locales/en.default.json': JSON.stringify({ hello: 'Hello' }),
Expand Down
2 changes: 1 addition & 1 deletion packages/theme-check-common/src/checks/matching-translations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const MatchingTranslations: JSONCheckDefinition = {
const hasDefaultTranslations = () => defaultTranslations.size > 0;
const isTerminalNode = ({ type }: JSONNode) => type === 'Literal';
const isPluralizationNode = (node: PropertyNode) => PLURALIZATION_KEYS.has(node.key.value);
const isShopifyPath = (path: string) => path.startsWith('shopify.');
const isShopifyPath = (path: string) => path.startsWith('shopify.') || path.startsWith('customer_accounts.');

const hasDefaultTranslation = (translationPath: string) =>
defaultTranslations.has(translationPath) ?? false;
Expand Down