Skip to content

Conversation

@prakashraman
Copy link
Contributor

@prakashraman prakashraman commented Nov 28, 2025

Resolves https://github.com/shop/issues-retail/issues/21304

Background

This PR refines the TypeScript definitions for the TextArea component in the Point of Sale UI extensions.

Solution

This change streamlines the type definitions by:

  • Removing the accessory prop from the TextAreaJSXProps interface

These changes make the type definitions more maintainable while preserving type safety.

🎩

  • Verified that existing components using TextArea still compile correctly
  • Confirmed that the type definitions work as expected in the Point of Sale surface

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prakashraman prakashraman changed the title Remove accessory capability/slot from TextArea component [WIP] Remove accessory capability/slot from TextArea component Nov 28, 2025
@prakashraman prakashraman marked this pull request as ready for review November 28, 2025 22:58
Copy link
Contributor Author

hmmm, I might need a second pair of eyes 👀 , to see if I generated the type docs properly.

I ran

BUILD_VERSION=2026-01 pnpm build-extension-components

Which generated the docs, however, when I

BUILD_VERSION=2026-01 pnpm build-extension-components:publish

over to the ui-extensions repo, I see quite more differences than I was expecting. As @BrittaEvansFenton suspected, could we have others making changes directly on this repo? Or are we supposed to manage these docs differently?

@prakashraman prakashraman force-pushed the 11-28-remove_accessory_capability_slot_from_textarea_component branch from 839cbe0 to be49ac7 Compare November 28, 2025 23:05
@prakashraman prakashraman changed the title [WIP] Remove accessory capability/slot from TextArea component Remove accessory capability/slot from TextArea component Dec 2, 2025
Copy link
Contributor Author

@BrittaEvansFenton thanks for walking me through my question above.

I've created a sub-issue for the docs, and have mentioned it at the top of the PR description.

Do review when you can.

@@ -0,0 +1,5 @@
---
'@shopify/ui-extensions': minor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a major change?

Copy link
Contributor Author

@prakashraman prakashraman Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm, I see what you mean. It is a breaking change in the sense that a behavior is no longer supported, but it does not break the build itself.

That being said, when I look at recent version history https://www.npmjs.com/package/@shopify/ui-extensions?activeTab=versions

It does not, anymore, follow a strict semver versioning right? It is now yyyy.mm.<patch>

I'm split on the change-level. I'll go with your advice - what shall we do? Shall we go with major?

And for my understanding, what would that version look like? (2026.02.01) ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmmm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't 2025 -> 2026 account for the major in this case anyways?

Copy link
Contributor Author

prakashraman commented Dec 10, 2025

Merge activity

  • Dec 10, 4:42 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 10, 4:43 PM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 10, 4:44 PM UTC: @prakashraman merged this pull request with Graphite.

@prakashraman prakashraman force-pushed the 11-28-remove_accessory_capability_slot_from_textarea_component branch from 055079f to 72817d1 Compare December 10, 2025 16:42
@prakashraman prakashraman merged commit 811f701 into 2026-01-rc Dec 10, 2025
5 checks passed
fatbattk added a commit that referenced this pull request Dec 15, 2025
fatbattk added a commit that referenced this pull request Dec 15, 2025
@frehner frehner mentioned this pull request Jan 8, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants