-
Notifications
You must be signed in to change notification settings - Fork 52
Remove accessory capability/slot from TextArea component #3603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove accessory capability/slot from TextArea component #3603
Conversation
|
hmmm, I might need a second pair of eyes 👀 , to see if I generated the type docs properly. I ran Which generated the docs, however, when I over to the |
839cbe0 to
be49ac7
Compare
|
@BrittaEvansFenton thanks for walking me through my question above. I've created a sub-issue for the docs, and have mentioned it at the top of the PR description. Do review when you can. |
.changeset/old-geese-smoke.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@shopify/ui-extensions': minor | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this not a major change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm, I see what you mean. It is a breaking change in the sense that a behavior is no longer supported, but it does not break the build itself.
That being said, when I look at recent version history https://www.npmjs.com/package/@shopify/ui-extensions?activeTab=versions
It does not, anymore, follow a strict semver versioning right? It is now yyyy.mm.<patch>
I'm split on the change-level. I'll go with your advice - what shall we do? Shall we go with major?
And for my understanding, what would that version look like? (2026.02.01) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmmm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't 2025 -> 2026 account for the major in this case anyways?
Merge activity
|
055079f to
72817d1
Compare

Resolves https://github.com/shop/issues-retail/issues/21304
Background
This PR refines the TypeScript definitions for the TextArea component in the Point of Sale UI extensions.
Solution
This change streamlines the type definitions by:
accessoryprop from theTextAreaJSXPropsinterfaceThese changes make the type definitions more maintainable while preserving type safety.
🎩
Checklist