Skip to content

fix: updated fallback color#10525

Merged
psshri merged 2 commits intomainfrom
SIG_9731
Mar 11, 2026
Merged

fix: updated fallback color#10525
psshri merged 2 commits intomainfrom
SIG_9731

Conversation

@ishan621
Copy link
Contributor

@ishan621 ishan621 commented Mar 9, 2026

Pull Request

Customer reported that the default color for severity_text (when no key is present) needed to be updated. Previously, we set it to gray, but this caused poor contrast in dark theme. We have now updated it to use the light background color, which provides better visibility and works well in both light and dark themes.

Earlier fix - https://github.com/SigNoz/engineering-pod/issues/3889
PR : #10389

Customer issue - https://app.usepylon.com/support/issues/views/12fbdb55-3637-4930-bb23-e152a5dbe87a?issueNumber=4523&view=fs&startTimeMs=1760466600000&endTimeMs=1761762599999

Screenshots / Screen Recordings (if applicable)

Before:
Screenshot 2026-03-09 at 9 11 45 AM

After :
Screenshot 2026-03-09 at 9 11 35 AM
Screenshot 2026-03-09 at 9 11 45 AM

Issues closed by this PR

#9731


✅ Change Type

Select all that apply

  • ✨ Feature
  • 🐛 Bug fix
  • ♻️ Refactor
  • 🛠️ Infra / Tooling
  • 🧪 Test-only

@ishan621 ishan621 requested a review from a team as a code owner March 9, 2026 03:48
@github-actions github-actions bot added the bug Something isn't working label Mar 9, 2026
Copy link
Contributor

@aks07 aks07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Just ensure this is inline with #9731 (comment)
and change made by @ahrefabhi for dashboards

@ishan621 ishan621 enabled auto-merge March 11, 2026 04:41
@ishan621 ishan621 disabled auto-merge March 11, 2026 06:48
@ishan621 ishan621 enabled auto-merge March 11, 2026 06:48
@ishan621 ishan621 added this pull request to the merge queue Mar 11, 2026
@psshri psshri removed this pull request from the merge queue due to a manual request Mar 11, 2026
@psshri psshri added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 25c513e Mar 11, 2026
16 checks passed
@psshri psshri deleted the SIG_9731 branch March 11, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants