Skip to content

fix: updated fallback color #10525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psshri merged 2 commits into from
Mar 11, 2026
+4 −4
Merged

fix: updated fallback color #10525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b89dd8
fix: updated fallback color
ishan621 Mar 9, 2026
a26297d
fix: updated testcase
ishan621 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/container/LogsExplorerChart/__tests__/frequencyGraphColor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { getColorsForSeverityLabels, isRedLike } from '../utils';

describe('getColorsForSeverityLabels', () => {
it('should return slate for blank labels', () => {
expect(getColorsForSeverityLabels('', 0)).toBe(Color.BG_SLATE_300);
expect(getColorsForSeverityLabels(' ', 0)).toBe(Color.BG_SLATE_300);
expect(getColorsForSeverityLabels('', 0)).toBe(Color.BG_VANILLA_400);
expect(getColorsForSeverityLabels(' ', 0)).toBe(Color.BG_VANILLA_400);
});

it('should return correct colors for known severity variants', () => {
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/container/LogsExplorerChart/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export function getColorsForSeverityLabels(
const trimmed = label.trim();

if (!trimmed) {
return Color.BG_SLATE_300;
return Color.BG_VANILLA_400; // Default color for empty labels
}

const variantColor = SEVERITY_VARIANT_COLORS[trimmed];
Expand Down Expand Up @@ -119,6 +119,6 @@ export function getColorsForSeverityLabels(

return (
SAFE_FALLBACK_COLORS[index % SAFE_FALLBACK_COLORS.length] ||
Color.BG_SLATE_400
Color.BG_VANILLA_400
);
}
Loading