Sync csa branch with main#878
Merged
Junior Martinez (jmartinez-silabs) merged 17 commits intomainfrom Mar 16, 2026
Merged
Conversation
* refactor: Replace fixed BSSID array size with constant for better maintainability * TEMP: added logs to understand flow of interface * Revert "TEMP: added logs to understand flow of interface" This reverts commit 5a31ca6. * Refactor and unify WiFi Credentials * Fix initialization of requested SSID span in WifiInterfaceImpl.cpp * Add static assertion for maximum length of WiFi BSSID in WiFiScanResponse * Remove static assertion for maximum length of WiFi BSSID in WiFiScanResponse
* parse the output and only get the last line for paths * added erros and continuation of script without input * address comments gemini
* Implement test script for TC_WEBRTCP_2_28 * Update src/python_testing/TC_WEBRTCP_2_28.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/python_testing/TC_WEBRTCP_2_28.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update src/python_testing/TC_WEBRTCP_2_28.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Update to use is_valid_uint_value in matter_asserts.py * Address review comments * if the DUT returns any error status, the test will fail with a clear message instead of an unhandled exception * Restyled by ruff * Update src/python_testing/TC_WEBRTCP_2_28.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
* [WebRTCP] Implement test script for test plan TC_WEBRTCP_2_31 * Address copilot comments * Address review comments * Address review comments * Add feature map read
* [WebRTCP] Implement test script for test plan TC_WEBRTCP_2_32 * Update src/python_testing/TC_WEBRTCP_2_32.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Address review comments --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
The check for |
…to close (#43565) * Fix TC_WEBRTC_1_6.py failure by ignoring NOT_FOUND status response on invoking EndSession The test case was failing as EndSession is called at step 9. Since on closing the browser popup, the peer connection gets closed. Some implementations can remove the session in CurrentSessions attribute on peer connection state switching to Closed/Disconnected. Hence it update TC_WEBRTC_1_6.py to ignore any NOT_FOUND status response for EndSession command. Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> * Address review comment: Silence only NotFound interaction response Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> --------- Signed-off-by: s-gatti <s.gatti@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Co-authored-by: s-gatti <s.gatti@samsung.com>
* tests: Improve test summary * Fix top slowest slicing when showing all * Fix typo * Ensure that status is TestStatus in case of importing from JSON * Treat dry run as a passed test * Explicitly log result exception on test failure * Add default TestResult(exception=None) * Use cls for run_test * Add no_content_msg for top_slowest * Add TypeError to timestamp recovery * Round floats to three decimal places * Print thread.pcap only on failure * Use pure Python instead of os.system for thread.pcap dump * Round floats only on JSON serialization --------- Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com>
* tests: Use enum to encode commissioning method CLI option * tests: Move deprecated flags to the bottom of option list Also, make the style of existing options more uniform. * tests: Use TestRunTime as click.Choice * tests: Don't use inverse logic for log-timestamps option * Make runtime match exhaustive * Update usage of CHIP_NO_LOG_TIMESTAMPS to CHIP_LOG_TIMESTAMPS * Use new log timestamps flag format in other places * Fix style * Restyled by isort --------- Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> Co-authored-by: Restyled.io <commits@restyled.io>
… and Action Delegation Methods (#43062) * Rename 'mpScanCallback' to 'mpOneShotScanCallback'. This more accurately reflects its set-scan-and-clear usage. * Documentation: Document the 'mpOneShotScanCallback' data member. * Rename 'mpConnectCallback' to 'mpOneShotConnectCallback'. This more accurately reflects its set-connect-and-clear usage. * Documentation: Document the 'mpOneShotConnectCallback' data member. * Added network commissioning-related action delegation methods. These three methods consolidate the handling and dispatch of scan, connect, and network status change action delegation callback invocation and, for scan and connect, post-invocation nullification. * Add parallel setters for all scan, connect, and status change callbacks. This not only makes it easier to keep callback members private as implementations fan out from the current, single wpa_supplicant implementation but also reduces duplication among those implementations for common callback-related operations. * Initialize callbacks in the explicit initializer only. Previously, the status change callback was initialized with a default initializer and the connect and scan callbacks were initialized in the explicit initializer. With this change, all three are now initialized in the explicit initializer. * Added two connect- and scan-related callback introspection methods. * Leverage callback introspection, mutation, and action delegation methods.
…ions (#43580) * Doc clarity on rename PR * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…sters (#43357) * [WIP] groupcast acl * Move aux acl to second delegate * Begin tests and debug build errors * More test debugging * Fix access control tests made, all passing * Add basic Check() function with auxiliary entries * Update auxiliary entries test to use equivalence class comparison * Create event, but failing tests * Merge conflicts * More fixes after rebase * Remove singleton getter for GroupAuxiliaryAccessControlDelegate * Restyle (run manually) * Restyled by clang-format * Restyled by gn * Update BUILD.gn * Fix test failures and re-format Init() call * Restyled by clang-format * Fix TODO's and tests * Fix Repl tests - keep auxiliary type unimplemented in example delegate * Restyled by whitespace * Restyled by clang-format * Poke CI * Revert "Poke CI" This reverts commit 1212cea5f0c98bcf7ba07ac15ec304ea3677d470. * Poke CI * Revert "Poke CI" This reverts commit ebb7d901b70bb97cc5ebf8c0ac9a3d6d9568ff65. * Add test with wrong privilege * Remove duplicate build dependency and unused variable * Fix mContext re-defintion from DefaultServerCluster * Restyled by clang-format * Add missing aux feature (in cluster and on all devices app), and add group aux delegate in example app * Restyled by clang-format * Address review comments * Restyled by whitespace * Restyled by clang-format * More review comments * Restyled by whitespace * Restyled by clang-format * Update event emitting logic * Restyled by whitespace * Restyled by clang-format * Fix build issues * Restyled by clang-format * Fix build issues * Allow non-fabric scoped entry reporting * Restyled by clang-format * Mark feature as ignored * Restyled by ruff * Fix asan failures on tests * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Decouple commissioner control cluster part 1 * Restyled by gn * Address review comments --------- Co-authored-by: Restyled.io <commits@restyled.io>
…43575) * setup: add pydantic-core constraint for Python 3.13+ compatibility pydantic-core < 2.20 ships no pre-built wheels for cp313 and attempts to build from source using PyO3 0.21.x which does not support Python 3.13+, causing bootstrap to fail. Add a version-gated constraint so pip resolves a compatible pydantic-core when running on Python >= 3.13. * suggestion from gemini
* tests: Introduce LogConfig Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * tests: Improve logging in Linux namespace setup Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix command output preservation for failed execution Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Don't use explicit ANSI escape sequenes in log format Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Fix style Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Move log_utils to logging Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Move logging to log_config Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Sort imports Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Move test context to TestResul.run_test() Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> * Don't pass test name to log functions in log context Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com> --------- Signed-off-by: Marek Pikuła <m.pikula@partner.samsung.com>
…wwww The `controlData` buffer is not initialized (set to zero) in function `UDPEndPointImplSockets::HandlePendingIO`. This could lead to an infinite loop when iterating over `struct cmsghdr` entries in `controlData` due to pointer arithmetic overflow when evaluating `cmsg_len` from uninitialized data. Seen in association with: https://github.com/nrfconnect/sdk-zephyr/blob/ff8f0c579eeb896876b6f36aca70c2bbfa756e19/subsys/net/lib/sockets/sockets_inet.c#L963
Junior Martinez (jmartinez-silabs)
approved these changes
Mar 16, 2026
96fdeea
into
main
88 of 89 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION