Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3d6c065
[Silabs] Clean up of Wi-Fi interface structures (#43567)
rosahay-silabs Mar 12, 2026
9d82864
[Silabs] : fix install script (#43568)
Sarthak-Shaha Mar 12, 2026
66b78a8
[WebRTCP] Implement test script for TC_WEBRTCP_2_28 (#43509)
yufengwangca Mar 12, 2026
a82052b
[WebRTCP] Implement test script for test plan TC_WEBRTCP_2_31 (#43532)
yufengwangca Mar 12, 2026
4c2c574
[WebRTCP] Implement test script for test plan TC_WEBRTCP_2_32 (#43533)
yufengwangca Mar 13, 2026
18f60c6
[Camera] Fix TC_WEBRTC_1_6 failure on not finding any WebRTC session …
chulspro Mar 13, 2026
038f6c4
[Tests] Improve test summary (#43555)
MarekPikula Mar 13, 2026
045f879
[Tests] run_test_suite CLI improvements (#43541)
MarekPikula Mar 13, 2026
fa956ce
Add and Leverage Linux Connectivity Callback Introspection, Mutation,…
gerickson Mar 13, 2026
70b86c8
[Doc] Better documentation on the rename PR for ember cluster convers…
andy31415 Mar 13, 2026
2403f0a
Reporting Auxiliary ACL Entries with Groupcast and Access Control Clu…
zaid-google Mar 13, 2026
cc97908
[Code Driven Cluster] commissioner control cluster part 1 (#43581)
arielsz71 Mar 14, 2026
0d30044
Generate WindowCovering with Alchemy (#43550)
tersal Mar 14, 2026
e14904c
setup: add pydantic-core constraint for Python 3.13+ compatibility (#…
shubhamdp Mar 15, 2026
a925c14
[Tests] Improve logger configuration (#43548)
MarekPikula Mar 15, 2026
6649dff
Add 1.5.1 and 1.6 to PICS Generator (#43558)
ReneJosefsen Mar 15, 2026
708056c
[inet] Fix UDPEndPointImplSockets uninitialized control data (#43593)…
MichaelHopfengaertnerTado Mar 15, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
build_linux_gcc_debug:
Expand Down Expand Up @@ -522,7 +522,7 @@ jobs:

env:
TSAN_OPTIONS: "halt_on_error=1 suppressions=scripts/tests/chiptest/tsan-linux-suppressions.txt"

if: github.actor != 'restyled-io[bot]' && github.actor != 'dependabot[bot]' && inputs.run-codeql != true
# Use namespace to get more disk space and slightly better performance (Compile and unit tests
# are CPU bound)
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chef.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
chef_linux_all_devices:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cirque.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
cirque:
name: Cirque
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
git config --global --add safe.directory '*' \
&& scripts/tests/cirque_tests.sh run_all_tests \
"
- name: Uploading Binaries
uses: actions/upload-artifact@v7
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/darwin-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
test_suites_chip_tool_darwin:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/darwin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,13 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
framework:
name: Build framework
if: github.actor != 'restyled-io[bot]'

strategy:
matrix:
os: [ macos-26 ]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/example-tv-casting-darwin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
tv-casting-bridge:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-ameba.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
ameba:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-asr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
asr:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-bouffalolab.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
bouffalolab:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-cc13xx_26xx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ concurrency:
'workflow_dispatch' && github.run_number) || github.sha }}
cancel-in-progress: true
env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
cc13xx_26xx:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-cc32xx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
cc32xx:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-efr32.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
efr32:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-esp32.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
esp32:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-infineon.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
infineon:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-linux-arm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false
CHIP_PW_COMMAND_LAUNCHER: ccache

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-linux-imx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
imx:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-linux-standalone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false
CHIP_PW_COMMAND_LAUNCHER: ccache

jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-nrfconnect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
nrfconnect:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-nuttx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
nuttx:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-nxp.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
FreeRTOS:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-qpg.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
qpg:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-realtek.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
FreeRTOS:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-stm32.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
stm32:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-telink.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
zephyr_latest:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/examples-tizen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
tizen:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/full-android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
full_android:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/fuzzing-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
build_linux_fuzzing:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/java-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
java_tests_linux:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/qemu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release_artifacts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ on:
required: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
esp32:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoketest-android.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
android:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
test_suites_linux:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/zap_regeneration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
zap_regeneration:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/zap_templates.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
cancel-in-progress: true

env:
CHIP_NO_LOG_TIMESTAMPS: true
CHIP_LOG_TIMESTAMPS: false

jobs:
zap_templates:
Expand Down
40 changes: 34 additions & 6 deletions docs/guides/migrating_ember_cluster_to_code_driven.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,16 +19,44 @@ smaller pull requests. This approach significantly simplifies the review
process, allowing reviewers to approve preliminary changes quickly. We recommend
the following sequence of PRs:

- [ ] **PR 1: File Renames Only.**
- [ ] **PR 1: File Renames and Moves Only.**

- If your migration involves renaming files, submit a PR containing _only_
the renames. A typical rename is from `<name>-server.cpp` to
`<Name>Cluster.cpp`.
- **Note:** For backward compatibility with code generation, it is often
best to **not** rename the header file.
the renames and file moves. This helps to isolate structural changes
from logic changes, making the review process easier.

- **`.cpp` file rename:**

- Rename `<name>-server.cpp` to `<Name>Cluster.cpp`. This is often a
good starting point as much of the implementation can be reused.
Renaming allows `git diff` to track changes more effectively than a
delete/add operation.

- **`.h` file renames and refactoring:**

- The legacy header (`<name>-server.h`) often contains a mix of legacy
API functions, delegate classes, and other definitions. To maintain
backward compatibility while moving to a code-driven model, we
recommend the following:
- Create a new `CodegenIntegration.h` header and move the
implementation portions of `<name>-server.h` into it. This new file
will be responsible for maintaining the legacy API integration logic
that interacts with the generated code.
- If `<name>-server.h` contains delegate classes or other distinct
components (e.g., `class FooDelegate`), move them into their own
header files (e.g., `FooDelegate.h`). A good rule of thumb is that
`class Bar` should live in `Bar.h`.
- After moving the implementation out of `<name>-server.h`, update
`<name>-server.h` itself to be a wrapper that simply includes the
new headers (`CodegenIntegration.h`, `FooDelegate.h`, etc.). This
preserves the include paths for existing code while allowing the
implementation to evolve.

- **Why:** This prevents `git diff` from becoming confused and showing the
entire file as deleted and recreated, making the actual code changes
impossible to review.
impossible to review. Separating file moves from logic changes is a
critical step for an efficient code review.

- _This type of PR can be reviewed and merged very quickly._

- [ ] **PR 2: Code Movement Only.**
Expand Down
Loading
Loading