fix: change _controller from a getter to a late field initialized during registration and add a scope registration check.#631
Open
dreyes17 wants to merge 1 commit intoSimformSolutionsPvtLtd:masterfrom
Conversation
…tion and add a scope registration check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The issue was caused by race conditions during widget rebuilds or scope transitions where the ShowcaseService state was temporarily out of sync with the Showcase widget.
showcase.dartLocal Controller Caching
_controllerto a locallatevariable.initState.didUpdateWidgetand_updateControllerValuesonly when necessary.Scope Registration Safety
_updateControllerValuesto checkShowcaseService.instance.isRegistered(scope: _scopeName)before calling
getScope.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Fix #597 : The error is very difficult to reproduce so I am still checking with the Crashlytics if any similar error may still arise