Skip to content

fix: change _controller from a getter to a late field initialized during registration and add a scope registration check. #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dreyes17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: change _controller from a getter to a late field initialized during registration and add a scope registration check. #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions lib/src/showcase/showcase.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,11 +538,7 @@ class _ShowcaseState extends State<Showcase> {
late final String _scopeName =
widget.scope ?? ShowcaseService.instance.getScope().name;

ShowcaseController get _controller => ShowcaseService.instance.getController(
key: widget.showcaseKey,
id: _uniqueId,
scope: _showCaseWidgetManager.name,
);
late ShowcaseController _controller;

late ShowcaseScope _showCaseWidgetManager;

Expand All @@ -553,7 +549,7 @@ class _ShowcaseState extends State<Showcase> {
super.initState();
_showCaseWidgetManager =
ShowcaseService.instance.getScope(scope: _scopeName);
ShowcaseController.register(
_controller = ShowcaseController.register(
id: _uniqueId,
key: widget.showcaseKey,
getState: () => this,
Expand Down Expand Up @@ -581,7 +577,7 @@ class _ShowcaseState extends State<Showcase> {
id: _uniqueId,
scope: _showCaseWidgetManager.name,
);
ShowcaseController.register(
_controller = ShowcaseController.register(
id: _uniqueId,
key: widget.showcaseKey,
getState: () => this,
Expand Down Expand Up @@ -615,6 +611,7 @@ class _ShowcaseState extends State<Showcase> {
}

void _updateControllerValues() {
if (!ShowcaseService.instance.isRegistered(scope: _scopeName)) return;
final manager = ShowcaseService.instance.getScope(scope: _scopeName);
if (manager == _showCaseWidgetManager) return;
_showCaseWidgetManager = manager;
Expand Down