-
Notifications
You must be signed in to change notification settings - Fork 6
Bindings for Eigen's decompositions, matrix solvers, and geometry module, and add stubs #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ManifoldFR
merged 111 commits into
Simple-Robotics:main
from
Lucas-Haubert:topic/decomps_geometry_solvers
Mar 28, 2025
Merged
Bindings for Eigen's decompositions, matrix solvers, and geometry module, and add stubs #1
ManifoldFR
merged 111 commits into
Simple-Robotics:main
from
Lucas-Haubert:topic/decomps_geometry_solvers
Mar 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-commit run --all-files
Member
|
Don't forget to turn on conda install pre-commit -y # or 'mamba install'
pre-commit install
pre-commit run --all --verbose |
…consume the Python module target
ManifoldFR
requested changes
Mar 19, 2025
Member
ManifoldFR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first round of feedback.
include/nanoeigenpy/decompositions/sparse/SimplicialCholesky.hpp
Outdated
Show resolved
Hide resolved
…l cholesky solvers do not inherit from EigenBase!
d8a365e to
7030e32
Compare
+ Expose nanoeigenpy.__version__
c1d915b to
4bcadfb
Compare
4bcadfb to
2f421b1
Compare
…l iterative solvers
…al guess), test info flag, increase max iters
Member
|
Fantastic work everyone, the CI is all green! We can now gear up for the first release. |
ManifoldFR
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Do not merge, tests have to be finished first ! (and local topic/decomps_geometry_solvers must be merged to local devel).
The aim of this branch is to add the following features:
In particular:
After this one is finished and merged: