[python] Remove/deprecate old headers which were upstreamed into eigenpy #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:
- build_collision (build Pinocchio with coal support)
- build_casadi (build Pinocchio with CasADi support)
- build_autodiff (build Pinocchio with CppAD support)
- build_codegen (build Pinocchio with CppADCodeGen support)
- build_extra (build Pinocchio with extra algorithms)
- build_mpfr (build Pinocchio with Boost.Multiprecision support)
- build_sdf (build Pinocchio with SDF parser)
- build_accelerate (build Pinocchio with APPLE Accelerate framework support)
- build_all (build Pinocchio with ALL the options stated above)
Thanks.
The Pinocchio development team.
ManifoldFR
changed the title
…o `<eigenpy/registration.hpp>` instead
…p` and `utils/deprecation.hpp`, include corresponding eigenpy headers instead
ManifoldFR
force-pushed
the
topic/cleanup-old-python-includes
branch
2 times, most recently
from
7508381 to
5331859
Compare
…ecated header) * reduce usage of some of the old headers * remove some line skips
ManifoldFR
force-pushed
the
topic/cleanup-old-python-includes
branch
from
f7b4a0b to
d1ec904
Compare
jorisv
requested changes
Jun 3, 2025
jorisv
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the minimal amount of changes here:
registration.hppentirely and using-declares eigenpy's function so we don't have to replace much codecopyable.hppanddeprecation.hppheaders, includes the corresponding eigenpy headers with using-declarations, and deprecates them.Resolves stack-of-tasks/issues/2694