Fix issue 97 #98
Open
Fix issue 97 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ybw0014
requested changes
Nov 11, 2025
| damageable.setDamage(damageable.getDamage() + event.getDamage()); | ||
| damagedItem.setItemMeta(im); | ||
| // fix issue 97: only when the event is not cancelled should we check durability and set damage | ||
| if(!event.isCancelled()){ |
Member
There was a problem hiding this comment.
Suggested change
| if(!event.isCancelled()){ | |
| if (!event.isCancelled()) { |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue 97 by preventing durability modifications from being processed when an item damage event has already been cancelled.
- Wraps durability modification logic in a check for
!event.isCancelled()to avoid unnecessary processing - Ensures that when traits or modifiers cancel damage events, the durability system respects that decision
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/io/github/sefiraat/slimetinker/listeners/DurabilityListener.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.