Skip to content

Fix issue 97 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m1919810 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue 97 #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions src/main/java/io/github/sefiraat/slimetinker/listeners/DurabilityListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,18 +68,20 @@ public void onItemDamage(PlayerItemDamageEvent event) {
if (friend.isCancelEvent()) {
event.setCancelled(true);
}

ItemMeta im = event.getItem().getItemMeta();
Damageable damageable = (Damageable) im;
event.setDamage((int) Math.ceil(event.getDamage() * friend.getDurabilityMod())); // Modify the damage taken

if ((damageable.getDamage() + event.getDamage()) >= event.getItem().getType().getMaxDurability()) { // This will break the tool, lets stop that!
damageable.setDamage(event.getItem().getType().getMaxDurability() - 1);
damagedItem.setItemMeta(im);
event.setCancelled(true);
} else if (event instanceof FakeItemDamageEvent) {
damageable.setDamage(damageable.getDamage() + event.getDamage());
damagedItem.setItemMeta(im);
// fix issue 97: only when the event is not cancelled should we check durability and set damage
if(!event.isCancelled()){
Copy link
Member

@ybw0014 ybw0014 Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(!event.isCancelled()){
if (!event.isCancelled()) {

ItemMeta im = event.getItem().getItemMeta();
Damageable damageable = (Damageable) im;
event.setDamage((int) Math.ceil(event.getDamage() * friend.getDurabilityMod())); // Modify the damage taken

if ((damageable.getDamage() + event.getDamage()) >= event.getItem().getType().getMaxDurability()) { // This will break the tool, lets stop that!
damageable.setDamage(event.getItem().getType().getMaxDurability() - 1);
damagedItem.setItemMeta(im);
event.setCancelled(true);
} else if (event instanceof FakeItemDamageEvent) {
damageable.setDamage(damageable.getDamage() + event.getDamage());
damagedItem.setItemMeta(im);
}
}
}

Expand Down
Loading