Skip to content

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Bug fix

Current Behavior

To replicate:

  • Have a final segment with multiple parts
  • Take the first part in the final segment
  • Queue a previous segment (Queue, not set as next)
  • Take remaining parts
  • Sofie gets stuck on final part with an error stating that there are no more parts (despite previous segment showing the little queue green triangle)

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

I suspect this will affect earlier releases too, but I am not setup to test in earlier versions

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Nov 26, 2024
@Julusian Julusian requested a review from a team as a code owner November 26, 2024 10:28
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.39%. Comparing base (175b5ff) to head (d7a216d).
Report is 38 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1330      +/-   ##
=============================================
- Coverage      60.65%   60.39%   -0.26%     
=============================================
  Files            461      461              
  Lines          78911    79502     +591     
  Branches        4456     5055     +599     
=============================================
+ Hits           47867    48019     +152     
- Misses         30948    31338     +390     
- Partials          96      145      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstarpl jstarpl merged commit 89ddacf into Sofie-Automation:release52 Nov 26, 2024
45 of 46 checks passed
@Julusian Julusian deleted the upstream/fix-queued-segment-when-on-last-part branch November 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants