Skip to content

fix: queuedSegmentId ignored when taking last part of the rundown #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jstarpl merged 1 commit into from
Nov 26, 2024
Merged

fix: queuedSegmentId ignored when taking last part of the rundown #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/job-worker/src/playout/__tests__/selectNextPart.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,4 +417,11 @@ describe('selectNextPart', () => {
expect(nextPart).toEqual({ index: 6, part: defaultParts[6], consumesQueuedSegmentId: false })
}
})

test('on last part, with queued segment', () => {
// On the last part in the rundown, with a queuedSegment id set to earlier
defaultPlaylist.queuedSegmentId = segment2
const nextPart = selectNextPart2(defaultParts[8].toPartInstance(), defaultParts[8].toPartInstance())
expect(nextPart).toEqual({ index: 4, part: defaultParts[4], consumesQueuedSegmentId: true })
})
})
2 changes: 1 addition & 1 deletion packages/job-worker/src/playout/selectNextPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ export function selectNextPart(

if (rundownPlaylist.queuedSegmentId) {
// No previous part, or segment has changed
if (!previousPartInstance || (nextPart && previousPartInstance.segmentId !== nextPart.part.segmentId)) {
if (!previousPartInstance || !nextPart || previousPartInstance.segmentId !== nextPart.part.segmentId) {
// Find first in segment
const newSegmentPart = findFirstPlayablePart(
0,
Expand Down
Loading