Skip to content

Conversation

@Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the BBC

Type of Contribution

This is a: Feature

New Behavior

This allows for more configuring of the system from blueprints.
Primarily, the Studio.settings property and some properties from CoreSystem are now inside of ObjectWithOverrides structures, and populated from applyConfig blueprint methods.

As part of this there is now an applyConfig method on the system blueprint to configure these as well as the system action triggers. The structure for this on the CoreSystem document is a little strange, as there is no blueprintConfig in place to drive this flow, but the properties were added so that the flow could be kept as close as possible to the studio and showstyle blueprints.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

Time Frame

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Nov 27, 2024
@Julusian Julusian requested a review from a team as a code owner November 27, 2024 17:34
@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 67.62061% with 396 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (11ddc3a) to head (f54bd28).
Report is 23 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/migration/upgrades/system.ts 18.51% 88 Missing ⚠️
meteor/server/migration/X_X_X.ts 60.00% 60 Missing ⚠️
...publications/blueprintUpgradeStatus/checkStatus.ts 6.25% 60 Missing ⚠️
...publications/blueprintUpgradeStatus/publication.ts 20.00% 44 Missing ⚠️
...ications/partInstancesUI/rundownContentObserver.ts 0.00% 25 Missing ⚠️
...ver/publications/partsUI/rundownContentObserver.ts 0.00% 25 Missing ⚠️
meteor/server/migration/upgrades/lib.ts 77.63% 17 Missing ⚠️
...blications/partInstancesUI/reactiveContentCache.ts 0.00% 11 Missing ⚠️
...erver/publications/partsUI/reactiveContentCache.ts 0.00% 11 Missing ⚠️
meteor/server/api/rest/v1/typeConversion.ts 0.00% 7 Missing ⚠️
... and 21 more
Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1332      +/-   ##
=============================================
- Coverage      61.31%   61.23%   -0.08%     
=============================================
  Files            468      472       +4     
  Lines          82107    82647     +540     
  Branches        4684     5370     +686     
=============================================
+ Hits           50340    50609     +269     
- Misses         31674    31923     +249     
- Partials          93      115      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian mentioned this pull request Dec 9, 2024
7 tasks
@Julusian Julusian force-pushed the upstream/blueprint-configure-system-settings branch from ade43cb to ef14c8f Compare December 10, 2024 15:26
@nytamin nytamin merged commit f54bd28 into Sofie-Automation:release52 Dec 11, 2024
46 checks passed
@Julusian Julusian deleted the upstream/blueprint-configure-system-settings branch December 11, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants