Skip to content

Conversation

@olzzon
Copy link
Contributor

@olzzon olzzon commented Jan 8, 2025

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a feature

Current Behavior

Currently there's only Script support in script layers

New Behavior

This PR adds support in VT's for scripts and FirstWords-LastWords in hover via Blueprints.
The feature should not change current behaviour unless it's added in Blueprints.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects the UI only

Time Frame

  • Not urgent, but we would like to get this merged into the in-development release.

Status

This PR had been tested and approved by bbc

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.44%. Comparing base (b87cd9f) to head (c77b6a5).
Report is 62 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1355      +/-   ##
=============================================
+ Coverage      55.71%   56.44%   +0.72%     
=============================================
  Files            384      401      +17     
  Lines          68508    72105    +3597     
  Branches        4203     4551     +348     
=============================================
+ Hits           38171    40698    +2527     
- Misses         30204    31273    +1069     
- Partials         133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Jan 8, 2025
@olzzon olzzon marked this pull request as ready for review January 15, 2025 09:02
@olzzon olzzon requested a review from a team as a code owner January 15, 2025 09:02
@nytamin nytamin merged commit c77b6a5 into Sofie-Automation:release52 Jan 22, 2025
34 checks passed
@nytamin nytamin added the Contribution External contribution label Jan 29, 2025
@Julusian Julusian deleted the upstream/vt-in-out-words branch February 4, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) Contribution External contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants