fix: make debug logging work and not cause infinite updates

[ianshade]

About the Contributor

This pull request is posted on behalf of TV 2 Norge

Type of Contribution

This is a:

Bug fix

Current Behavior

The Activate debug logging for device option seemingly does nothing. No debug logs are printed when toggled on. However, when toggled while a device is already enabled, it causes an infinite sequence of update operations.

New Behavior

Debug logging works, and the operation updates properties needed for later comparison with potentially changed options. Null/undefined values are treated correctly.

Testing Instructions

• Enable a device after setting Activate debug logging for device option to on and off. Check if there's a difference in logs depending on the value.
• While a device is enabled, toggle Activate debug logging for device option on and off. Check if there's a difference in logs depending on the value.

In both cases, a device capable of outputting debug logs should be used, and playout actions should be performed in order to provoke the logs.

Other Information

Draft. Might add unit tests

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ne-state-resolver/src/service/ConnectionManager.ts	33.33%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!