Skip to content

fix: make debug logging work and not cause infinite updates #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ianshade wants to merge 1 commit into
base: release52
Choose a base branch
from
Draft

fix: make debug logging work and not cause infinite updates #380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/timeline-state-resolver/src/service/ConnectionManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,7 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
// see if it should be restarted because of an update
if (connectionConfigHasChanged(connection, config)) {
operations.push({ operation: 'update', id: deviceId })
} else if (
connection.deviceOptions.debug !== config.debug ||
connection.deviceOptions.debugState !== config.debugState
) {
} else if (connection.debugLogging !== !!config.debug || connection.debugState !== !!config.debugState) {
// see if we should set the debug params
operations.push({ operation: 'setDebug', id: deviceId })
}
Expand Down Expand Up @@ -304,8 +301,8 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
if (!connection || !config) return

try {
await connection.device.setDebugLogging(config.debug ?? false)
await connection.device.setDebugState(config.debugState ?? false)
await connection.setDebugLogging(!!config.debug)
await connection.setDebugState(!!config.debugState)
} catch {
this.emit('warning', 'Failed to update debug values for ' + id)
}
Expand Down
Loading