JACOCO-95 Fix warning log for multi-value property#166
Merged
leonardo-pilastri-sonarsource merged 2 commits intomasterfrom Feb 17, 2026
Merged
JACOCO-95 Fix warning log for multi-value property#166leonardo-pilastri-sonarsource merged 2 commits intomasterfrom
leonardo-pilastri-sonarsource merged 2 commits intomasterfrom
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
leonardo-pilastri-sonarsource
force-pushed
the
lp/fix-warning-log
branch
from
8d51a89 to
c3a0ce9
Compare
dorian-burihabwa-sonarsource
approved these changes
Feb 17, 2026
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
LGTM 👍🏿 If we have a chance to rename the variable in the test, I think it would help track down all of the places where we have the singular version of the parameter in the project
| @@ -59,7 +60,7 @@ void should_add_sensors_and_property_definitions() { | |||
| PropertyDefinition aggregateReportPath = (PropertyDefinition) arg.getAllValues().get(4); | |||
Contributor
There was a problem hiding this comment.
Let's rename the variable to remove the singular-plural confusion
Suggested change
| PropertyDefinition aggregateReportPath = (PropertyDefinition) arg.getAllValues().get(4); | |
| PropertyDefinition aggregateReportPaths = (PropertyDefinition) arg.getAllValues().get(4); |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of