SONARJAVA-5802 New analysis parameter: sonar.java.failOnStackOverflow (true by default) #5323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
leonardo-pilastri-sonarsource
force-pushed
the
lp/should-fail-on-stackoverflow
branch
from
6f7a81d to
08f6d26
Compare
leonardo-pilastri-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
requested changes
Oct 21, 2025
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
The change looks good but I still have a couple of nitpicks around the name of the parameter and potential documentation challenges.
java-frontend/src/main/java/org/sonar/java/SonarComponents.java
Outdated
Show resolved
Hide resolved
java-frontend/src/test/java/org/sonar/java/ast/JavaAstScannerTest.java
Outdated
Show resolved
Hide resolved
java-frontend/src/test/java/org/sonar/java/ast/JavaAstScannerTest.java
Outdated
Show resolved
Hide resolved
java-frontend/src/main/java/org/sonar/java/SonarComponents.java
Outdated
Show resolved
Hide resolved
leonardo-pilastri-sonarsource
requested a review
from dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource
approved these changes
Oct 22, 2025
Contributor
dorian-burihabwa-sonarsource
left a comment
dorian-burihabwa-sonarsource
left a comment
There was a problem hiding this comment.
LGTM 👍🏿 I would just change the name of the method source providing arguments to make it easier to lookup
java-frontend/src/test/java/org/sonar/java/ast/JavaAstScannerTest.java
Outdated
Show resolved
Hide resolved
|
leonardo-pilastri-sonarsource
deleted the
lp/should-fail-on-stackoverflow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5802
Part of MMF-5028
This PR aims to introduce a new analysis parameter specific to SonarJava, to allow the analysis to graciously handle StackOverflow errors and continue through the analysis.
The main reason for this new option (which does not change the default behavior of the analyzer) is to allow large codebases of AI-generated code to run through a complete analysis in order to get the results and re-iterate in what could be an agentic workflow.
This change should enable external tools to benefit more from the analyzer