Prepare release 8.22.1 #5387
Merged
Prepare release 8.22.1 #5387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
dorian-burihabwa-sonarsource
changed the title
dorian-burihabwa-sonarsource
requested a review
from tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource
requested changes
Jan 9, 2026
Contributor
tomasz-tylenda-sonarsource
left a comment
tomasz-tylenda-sonarsource
left a comment
There was a problem hiding this comment.
Please revert unwanted change due to disabled macro. Otherwise the PR is good,
| <p>If it is possible to disable JavaScript in the WebView, this is the most secure option. By default, JavaScript is disabled in a WebView, so | ||
| <code>webSettings.setJavaScriptEnabled(false)</code> does not need to be explicitly called. Of course, sometimes it is necessary to enable JavaScript, | ||
| in which case the following recommendations should be considered.</p> | ||
| <code>{setJavaScriptEnabledSnippet}</code> does not need to be explicitly called. Of course, sometimes it is necessary to enable JavaScript, in which |
Contributor
There was a problem hiding this comment.
We discovered that this is some sort of a macro that was incorrectly disabled in SonarSource/rspec#5968
See: https://github.com/search?q=repo%3ASonarSource%2Frspec%20setJavaScriptEnabledSnippet&type=code
Contributor
Author
There was a problem hiding this comment.
It should be fixed now. And I can confirm that using the latest version of the rule-api does not help preventing the problem here.
Add missing security standards.
dorian-burihabwa-sonarsource
force-pushed
the
db/prepare-release-8.22.1
branch
from
75fe7f8 to
17bae7c
Compare
dorian-burihabwa-sonarsource
requested a review
from tomasz-tylenda-sonarsource
tomasz-tylenda-sonarsource
approved these changes
Jan 9, 2026
dorian-burihabwa-sonarsource
force-pushed
the
db/prepare-release-8.22.1
branch
from
6104785 to
17bae7c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.