-
Notifications
You must be signed in to change notification settings - Fork 2
SONARSCALA-122 : License packaging standard II - use build-logic/common submodule for maintainability #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c42bc1c
Upgrade gradle wrapper to 9.3.1 and switch to com.gradleup.shadow
rombirli 6895573
Fix build - upgrade shadow and spotless
rombirli 60651f4
remove buildSrc folder
rombirli 94fef46
Add submodule
rombirli 1892c14
Update plugin to use the submodule
rombirli 8459bec
Add submodules true to build yml to fix ci
rombirli bda0ad5
Update generated licenses
rombirli 6ebf651
Try to fix ci 2 : only init needed submodule in build yml
rombirli 31d4582
Try to fix ci 2 : init buildlogic/common submodule also in QA
rombirli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| [submodule "its/sources"] | ||
| path = its/sources | ||
| url = https://github.com/SonarSource/slang-test-sources.git | ||
| [submodule "build-logic/common"] | ||
| path = build-logic/common | ||
| url = https://github.com/SonarSource/cloud-native-gradle-modules |
This file was deleted.
Oops, something went wrong.
117 changes: 0 additions & 117 deletions
117
buildSrc/src/main/kotlin/license-file-generator.gradle.kts
This file was deleted.
Oops, something went wrong.
174 changes: 0 additions & 174 deletions
174
buildSrc/src/main/kotlin/org/sonarsource/scala/gradle/AnalyzerLicensingPackagingRenderer.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actions/checkouthas parameterwith: submodules: true / recursive. Is there any reason not to use it and prefer a separate git command?I don't know much about submodules, so this is not a request to change the code, but an actual question from my side?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I tried it here 8459bec and there was an issue, I don't remember the exact error, but it was related to the the other submodule slang-test-sources so i fixed it here 6ebf651 by only initializing cloud-native-gradle-modules