Skip to content

SONARSCALA-122 : License packaging standard II - use build-logic/common submodule for maintainability#115

Merged
rombirli merged 9 commits intomasterfrom
rombirli/license-packaging-standard
Mar 5, 2026
Merged

SONARSCALA-122 : License packaging standard II - use build-logic/common submodule for maintainability#115
rombirli merged 9 commits intomasterfrom
rombirli/license-packaging-standard

Conversation

@rombirli
Copy link
Contributor

@rombirli rombirli commented Mar 5, 2026

No description provided.

@hashicorp-vault-sonar-prod
Copy link
Contributor

hashicorp-vault-sonar-prod bot commented Mar 5, 2026

SONARSCALA-122

@rombirli rombirli force-pushed the rombirli/license-packaging-standard branch from 7554194 to d5ca596 Compare March 5, 2026 10:53
@rombirli rombirli force-pushed the rombirli/license-packaging-standard branch from 7a5cb2c to 0a9f8f8 Compare March 5, 2026 12:35
@rombirli rombirli force-pushed the rombirli/license-packaging-standard branch from 0a9f8f8 to 31d4582 Compare March 5, 2026 12:48
@rombirli rombirli marked this pull request as ready for review March 5, 2026 12:48
@sonarqube-next
Copy link

sonarqube-next bot commented Mar 5, 2026

deployed: ${{ steps.build-step.outputs.deployed }}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Initialize build-logic submodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout has parameter with: submodules: true / recursive. Is there any reason not to use it and prefer a separate git command?

I don't know much about submodules, so this is not a request to change the code, but an actual question from my side?

Copy link
Contributor Author

@rombirli rombirli Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I tried it here 8459bec and there was an issue, I don't remember the exact error, but it was related to the the other submodule slang-test-sources so i fixed it here 6ebf651 by only initializing cloud-native-gradle-modules

@rombirli rombirli merged commit 2bd382a into master Mar 5, 2026
10 checks passed
@rombirli rombirli deleted the rombirli/license-packaging-standard branch March 5, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants