Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ jobs:
deployed: ${{ steps.build-step.outputs.deployed }}
steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Initialize build-logic submodule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout has parameter with: submodules: true / recursive. Is there any reason not to use it and prefer a separate git command?

I don't know much about submodules, so this is not a request to change the code, but an actual question from my side?

Copy link
Contributor Author

@rombirli rombirli Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I tried it here 8459bec and there was an issue, I don't remember the exact error, but it was related to the the other submodule slang-test-sources so i fixed it here 6ebf651 by only initializing cloud-native-gradle-modules

run: git submodule update --init build-logic/common
- uses: jdx/mise-action@5ac50f778e26fac95da98d50503682459e86d566 # v3.2.0
with:
version: 2025.7.12
Expand Down Expand Up @@ -65,6 +67,8 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
submodules: ${{ matrix.item.suite == 'ruling' }}
- name: Initialize build-logic submodule
run: git submodule update --init build-logic/common
- name: Remove kotlin ITs as they are not relevant for ruling tests (and cause issues with wrapper validation)
if: ${{ matrix.item.suite == 'ruling' }}
run: rm -r ./its/sources/kotlin
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[submodule "its/sources"]
path = its/sources
url = https://github.com/SonarSource/slang-test-sources.git
[submodule "build-logic/common"]
path = build-logic/common
url = https://github.com/SonarSource/cloud-native-gradle-modules
1 change: 1 addition & 0 deletions build-logic/common
Submodule common added at f029d6
12 changes: 0 additions & 12 deletions buildSrc/build.gradle.kts

This file was deleted.

117 changes: 0 additions & 117 deletions buildSrc/src/main/kotlin/license-file-generator.gradle.kts

This file was deleted.

This file was deleted.

Loading
Loading