Fix probe refresh #196
Merged
Fix probe refresh #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejoe91
reviewed
Oct 31, 2025
spikeinterface_gui/probeview.py
Outdated
| for label in self.channel_labels: | ||
| label.hide() | ||
|
|
||
| self._qt_on_unit_visibility_changed() |
There was a problem hiding this comment.
Maybe there should be a function called _qt_highlight_visible_units that does all the work. Then this could be self._qt_highlight_visible_units() and:
def _qt_on_unit_visibility_changed(self):
self._qt_highlight_visible_units()
I know it's subtle, but the on visible unit changed is only called when a on_unit_visibility_changed signal is triggered.
What do you think?
There was a problem hiding this comment.
Yeah, makes sense. So on_unit_visibility_changed is a special function reserved exclusively for when the unit ids change. Nice. Does this work?
(I snuck in another bug fix...)
samuelgarcia
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current qt probe refresh doesn't work properly