Skip to content

Fix probe refresh #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

Fix probe refresh #196

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72d6be7
fix probe refresh
chrishalcrow Oct 30, 2025
1b6e023
respond alessio
chrishalcrow Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spikeinterface_gui/probeview.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ def _qt_refresh(self):
for label in self.channel_labels:
label.hide()

self._qt_on_unit_visibility_changed()
Copy link
Member

@alejoe91 alejoe91 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there should be a function called _qt_highlight_visible_units that does all the work. Then this could be self._qt_highlight_visible_units() and:

def _qt_on_unit_visibility_changed(self):
   self._qt_highlight_visible_units()

I know it's subtle, but the on visible unit changed is only called when a on_unit_visibility_changed signal is triggered.
What do you think?

Copy link
Member Author

@chrishalcrow chrishalcrow Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense. So on_unit_visibility_changed is a special function reserved exclusively for when the unit ids change. Nice. Does this work?
(I snuck in another bug fix...)


def _qt_update_channel_visibility_from_roi(self, emit_signals=False):
r, x, y = circle_from_roi(self.roi_channel)
Expand Down