Conversation
|
|
||
| FROM app AS test | ||
|
|
||
| RUN datasets -h &&\ |
There was a problem hiding this comment.
It looks like you're adding some custom scripts. Can you add some sort of test to make sure they work?
There was a problem hiding this comment.
It's good that at least the help options are pulled up, showing the scripts can be called and the python packages are accessible to those scripts
I don't think it's truly necessary to test out each script unless Kutluhan has an easy way to add some tests in.
I'd be OK to merge as is, considering this docker image is purpose built for C-BIRD. I imagine he will do testing of those scripts via the C-BIRD workflow prior to the next release.
There was a problem hiding this comment.
Thank you @kapsakcj and @erinyoung. I already prepared a test folder and a script for that. I don't mind adding it here.
There was a problem hiding this comment.
Nice, thanks for adding those 👍 Looks good to me:
#14 [test 2/2] RUN cd /test && ./test.sh
#14 0.954 test_report.docx was created!
#14 1.283 test_basic_report.html was created!
#14 1.283 test_extended_report.html was created!
#14 1.943 test_QC_summary.html was created!
#14 DONE 2.0s
|
Looks good to me! I'm going to merge this and deploy to dockerhub and quay. |
|
You can check the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/13161632015 |
This is part of my C-BIRD pipeline.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)