Skip to content

adds genoflu 1.06#1196

Merged
erinyoung merged 3 commits intomasterfrom
cjk-genoflu
Feb 13, 2025
Merged

adds genoflu 1.06#1196
erinyoung merged 3 commits intomasterfrom
cjk-genoflu

Conversation

@kapsakcj
Copy link
Copy Markdown
Collaborator

@kapsakcj kapsakcj commented Feb 10, 2025

Closes #1193

  • updated base image to a more recent micromamba base image
  • genoflu version increased to 1.06-0 (bioconda tag)
  • added mention of important dependencies to genoflu readme
  • updated/fixed relative links in main /README.md

Here's the diff of the dockerfile and genoflu readme.

$ diff build-files/genoflu/1.05/ build-files/genoflu/1.06/
diff build-files/genoflu/1.05/Dockerfile build-files/genoflu/1.06/Dockerfile
1c1
< FROM mambaorg/micromamba:1.5.8 AS app
---
> FROM mambaorg/micromamba:2.0.5-ubuntu22.04 AS app
6c6
< ARG GENOFLU_VER="1.05-0"
---
> ARG GENOFLU_VER="1.06-0"
9c9
< LABEL base.image="micromamba:1.5.8"
---
> LABEL base.image="micromamba:2.0.5-ubuntu22.04"
32d31
< 
52c51
<   genoflu.py -f test-genome-A1.fasta 
\ No newline at end of file
---
>   genoflu.py -f test-genome-A1.fasta
diff build-files/genoflu/1.05/README.md build-files/genoflu/1.06/README.md
8a9,14
> - biopython 1.85
> - ncbi-blast 2.16.0
> - numpy 2.0.2
> - pandas 2.2.3
> - python 3.9.21
> 

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj kapsakcj marked this pull request as ready for review February 10, 2025 18:41
@erinyoung
Copy link
Copy Markdown
Contributor

The tests worked

#10 [test 2/2] RUN wget -q https://raw.githubusercontent.com/USDA-VS/GenoFLU/main/test/test-genome-A1.fasta &&   genoflu.py -f test-genome-A1.fasta
#10 1.034 
#10 1.034 genoflu.py set arguements:
#10 1.034 
#10 1.034 	FASTA:  test-genome-A1.fasta
#10 1.034 	FASTA_dir:  None
#10 1.034 	pident_threshold:  98.0
#10 1.034 	cross_reference:  None
#10 1.034 	sample_name:  None
#10 1.034 	debug:  False
#10 1.034 
#10 1.034 
#10 1.034 
#10 1.034 test-genome-A1 Genotype --> A1: PB2:ea1, PB1:ea1, PA:ea1, HA:ea1, NP:ea1, NA:ea1, MP:ea1, NS:ea1 at percent identity at 98.0
#10 1.034 
#10 DONE 1.1s

Copy link
Copy Markdown
Contributor

@erinyoung erinyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no changes to recommend. I'm going to merge and deploy this.

@erinyoung erinyoung merged commit b595930 into master Feb 13, 2025
2 checks passed
@erinyoung
Copy link
Copy Markdown
Contributor

You can check the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/13297342918

Thank you for putting this together!!!

@kapsakcj kapsakcj deleted the cjk-genoflu branch February 13, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request An Update]: add genoflu 1.06

2 participants