Skip to content

Conversation

@erinyoung
Copy link
Contributor

There's a new version of table2asn!

There aren't release notes, but sqlite is now a dependency.

I copied the files from the prior version, and updated the version args.

The full diff

$ diff build-files/ncbi-table2asn/1.29.*/Dockerfile
1c1
< ARG RELEASE_DATE="2025-03-03"
---
> ARG RELEASE_DATE="2025-09-16"
7c7
< ARG TABLE2ASN_VER="1.29.1151"
---
> ARG TABLE2ASN_VER="1.29.324"
24c24,25
<   libidn12 && \
---
>   libidn12 \
>   libsqlite3-0 && \

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@kapsakcj
Copy link
Collaborator

Looks like the tests passed:

#12 [test 3/3] RUN wget https://ftp.ncbi.nlm.nih.gov/asn1-converters/versions/2025-09-16/documentation/short.fsa &&   wget https://ftp.ncbi.nlm.nih.gov/asn1-converters/versions/2025-09-16/documentation/SubmissionTemplate.sbt &&   table2asn -i short.fsa  &&   table2asn -t SubmissionTemplate.sbt -i short.fsa -o helicase.sqn
#12 0.047 --2025-12-30 19:28:31--  https://ftp.ncbi.nlm.nih.gov/asn1-converters/versions/2025-09-16/documentation/short.fsa
#12 0.050 Resolving ftp.ncbi.nlm.nih.gov (ftp.ncbi.nlm.nih.gov)... 130.14.250.12, 130.14.250.31, 130.14.250.7, ...
#12 0.124 Connecting to ftp.ncbi.nlm.nih.gov (ftp.ncbi.nlm.nih.gov)|130.14.250.12|:443... connected.
#12 0.264 HTTP request sent, awaiting response... 200 OK
#12 0.403 Length: 13972 (14K)
#12 0.403 Saving to: 'short.fsa'
#12 0.403 
#12 0.403      0K .......... ...                                        100%  351K=0.04s
#12 0.442 
#12 0.443 2025-12-30 19:28:32 (351 KB/s) - 'short.fsa' saved [13972/13972]
#12 0.443 
#12 0.447 --2025-12-30 19:28:32--  https://ftp.ncbi.nlm.nih.gov/asn1-converters/versions/2025-09-16/documentation/SubmissionTemplate.sbt
#12 0.449 Resolving ftp.ncbi.nlm.nih.gov (ftp.ncbi.nlm.nih.gov)... 130.14.250.31, 130.14.250.7, 130.14.250.10, ...
#12 0.451 Connecting to ftp.ncbi.nlm.nih.gov (ftp.ncbi.nlm.nih.gov)|130.14.250.31|:443... connected.
#12 0.591 HTTP request sent, awaiting response... 200 OK
#12 0.730 Length: 2039 (2.0K)
#12 0.730 Saving to: 'SubmissionTemplate.sbt'
#12 0.730 
#12 0.730      0K .                                                     100% 1.49G=0s
#12 0.730 
#12 0.730 2025-12-30 19:28:32 (1.49 GB/s) - 'SubmissionTemplate.sbt' saved [2039/2039]
#12 0.730 
#12 0.735 Will be using one threads
#12 0.738 Falling back on built-in data for popular organisms.
#12 0.743 Will be using one threads
#12 0.747 Falling back on built-in data for popular organisms.
#12 DONE 0.8s

FROM ubuntu:jammy AS app

# version doesn't show appear anywhere on ftp; only can be determined via command-line
# this docker image was built 2022-12-13 and this was the current version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe delete this comment line? looks like carry over from the last dockerfile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may be even older than the last Dockerfile. I've updated it for clarity.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Updated comments to clarify versioning and directory structure.
@kapsakcj kapsakcj merged commit 775f24e into StaPH-B:master Jan 5, 2026
2 checks passed
@kapsakcj
Copy link
Collaborator

kapsakcj commented Jan 5, 2026

Thanks for this PR. Deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/20725750992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants