-
Notifications
You must be signed in to change notification settings - Fork 136
adding table2asn version 1.29.324 #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like the tests passed: |
| FROM ubuntu:jammy AS app | ||
|
|
||
| # version doesn't show appear anywhere on ftp; only can be determined via command-line | ||
| # this docker image was built 2022-12-13 and this was the current version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe delete this comment line? looks like carry over from the last dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be even older than the last Dockerfile. I've updated it for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
Updated comments to clarify versioning and directory structure.
|
Thanks for this PR. Deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/20725750992 |
There's a new version of table2asn!
There aren't release notes, but sqlite is now a dependency.
I copied the files from the prior version, and updated the version args.
The full diff
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)