-
Notifications
You must be signed in to change notification settings - Fork 136
adding augur version 32.1.0 #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
build-files/augur/32.1.0/Dockerfile
Outdated
| --sequence-index results/sequence_index.tsv \ | ||
| --metadata data/metadata.tsv \ | ||
| --exclude config/dropped_strains.txt \ | ||
| --output results/filtered.fasta \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be changed to --output-sequences results/filtered.fasta as --output is deprecated and will be removed in the next major release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only the case with augur filter? Or are there others that need to be updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, yes. I was going off of warnings in the the original github actions workflow and they have disappeared after your latest commit. Thanks for changing that!
kapsakcj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests passed, just have one request for altering an output flag for the augur filter. Also request that the versions of dependencies in the readme are updated to reflect what was installed via pip
Updated dependencies and added additional tools installed via pip.
|
I have updated the readme with the updated dependency versions, which now includes a full list of dependencies installed via pip in a dropdown. I also updated the usage in the README to reflect the same usage of |
kapsakcj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making those changes I requested 👍 LGTM
|
Thanks for the PR! Deploy workflow here: https://github.com/StaPH-B/docker-builds/actions/runs/20784583257 |
There's a new version of augur!
According to the release notes there are some new features and bug fixes.
I copied the files from 32.0.0 and updated the version args for augur and seqkit.
The full diff:
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)