Skip to content

Conversation

@cwoodside1278
Copy link
Contributor

@cwoodside1278 cwoodside1278 commented Feb 11, 2026

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Description

This PR adds myloasm version 0.4.0 to the docker-builds repository.

Changes include:

  • Created new directory structure: build-files/myloasm/0.4.0/
  • Added Dockerfile for myloasm version 0.4.0
  • Added container-specific to reflect the new version
  • Updated main to include version 0.4.0 in the myloasm versions dropdown
  • Note: I copied the Dockerfile from version 0.3.0 and updated the version number to 0.4.0.
    I was unable to test the Docker build locally. (please let me know if I need to do this in the future)
  • Did not update the Program Licenses (did not seem applicable)

@kapsakcj
Copy link
Collaborator

Not sure why the test is failing. Any ideas @Kincekara ? I tried upgrading the base image to ubuntu:noble as well as reducing the threads used in the test and it doesn't seem to be happy about what looks like an intermediate file test/initial_polished.fa

#9 12.74 (2026-02-11 04:51:39.665) INFO [myloasm] Analyzing coverage and filtering low-quality unitigs...
#9 12.74 (2026-02-11 04:51:39.665) INFO [myloasm::map_processing] Coverage analysis complete: flagged 0 regions, filtering 0 unitigs
#9 12.74 (2026-02-11 04:51:39.665) INFO [myloasm::map_processing] Poor coverage regions written to: test/3-mapping/low_quality_regions.bed
#9 12.74 (2026-02-11 04:51:39.665) INFO [myloasm] Time elapsed for coverage filtering is 428.581µs
#9 12.74 (2026-02-11 04:51:39.665) INFO [myloasm] Polishing final contigs...
#9 12.75 (2026-02-11 04:51:39.672) INFO [myloasm] Time elapsed for polishing is 361.854142ms
#9 12.75 (2026-02-11 04:51:39.672) INFO [myloasm] Dereplicating polished contigs with skani...
#9 12.75 (2026-02-11 04:51:39.672) WARN [skani::file_io] test/initial_polished.fa is not a valid fasta/fastq file; skipping.
#9 12.75 
#9 12.75 thread 'main' panicked at /homes9/jshaw/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/iter/traits/iterator.rs:2001:9:
#9 12.75 capacity overflow
#9 12.75 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

It's possible this is a bug with v0.4.0 of myloasm, I'm not really sure...

@erinyoung erinyoung changed the title Cwoodside1278 patch 3 Adding Myloasm version 0.4.0 Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants