Updated Poppunk to version 2.7.8#1558
Merged
erinyoung merged 16 commits intoStaPH-B:masterfrom Feb 18, 2026
Merged
Conversation
fixing the bug for the conda environment
trying another code line. so far there is still an issue/error
trying another fix
another fix to see if this fixes it
Curtis gave me a line of code for pkg_resources, but I kept my line about setuptools to make sure it works
Trying now with python 3.11, because online swears that 3.12 has setuptools issues
Let's try an older version of setuptools
Added a diagnostic line to verify the setuptools version
The docker finally worked! But I used setuptools version 80.9.0. I want to see if a slightly newer version works
The version 80.10.2 worked, but I want to try with this one now to see if it still works. If not I will go bacl
erinyoung
approved these changes
Feb 18, 2026
Contributor
|
Tests worked |
Contributor
|
I have no changes to recommend. Let's get this merged and deployed |
Contributor
|
Thank you for putting this together! You can check on the status of the deploy here : https://github.com/StaPH-B/docker-builds/actions/runs/22155750038 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Description
Updated poppunk to 2.7.8 from 2.7.7
Diff Output
It became very long sorry. I think it was because I updated the README
Test output run