Update Seqsender to 1.3.93 version#1568
Merged
erinyoung merged 10 commits intoStaPH-B:masterfrom Mar 2, 2026
Merged
Conversation
actually should be 1.3.93
Contributor
|
Tests worked |
Contributor
|
This PR has a file at build-files/docker-builds that I don't have permissions to move. Could this file be deleted? |
Contributor
Author
|
@erinyoung Which file is it? |
Contributor
|
The file is |
Contributor
Author
|
Yes I see it you can delete it! Not sure where that came from. I can't delete it. |
Contributor
|
I can't delete it from the PR. Can you try something like the following (on the command line) # De-initialize the submodule
git submodule deinit -f build-files/docker-builds
# Remove it from the index
git rm -f build-files/docker-builds
# Remove leftover metadata
rm -rf .git/modules/build-files/docker-builds
# Remove entry from .gitmodules (if present)
# Edit .gitmodules and delete the section for that submodule
git add .gitmodules
git commit -m "Remove accidentally added submodule"
# Push back to this PR
git pushPlease forgive any typos I may have introduced! |
Contributor
Author
|
Okay I got it! It should be gone now @erinyoung |
Contributor
|
thank you for putting this together! You can check the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/22588147204 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Description
Updated seqsender to 1.3.93 from 1.3.9
Diff Output
I sent a PR for 1.3.9, but since it hasn't been reviewed and merged with the main branch yet, I wasn't able to compare the two files. This is a comparison to the previous version 1.3.6.
diff -r build-files/seqsender/1.3.93/Dockerfile build-files/seqsender/1.3.6/Dockerfile
Test Build Output