Merged
Conversation
Collaborator
Author
|
I have commented out the real data test. This is ready for review. |
Contributor
|
I don't see any changes to recommend. I should have time to build this locally sometime by the end of the week to ensure it passes. |
Contributor
|
I've started building it to test now. |
Contributor
|
These are the result files: It looks like everything ran. I'll merge this, get it deployed, and set the quay repo to public. |
erinyoung
approved these changes
Mar 9, 2026
Contributor
|
Thank you for putting this together. You can check on the status of the deployment here : https://github.com/StaPH-B/docker-builds/actions/runs/22863120173 |
Contributor
|
And I've made the quay.io repo public: https://quay.io/repository/staphb/hifiasm-meta |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fork of hifiasm for the metagenomic hifi reads.
The test fails on GitHub because of low RAM, but it works on my computer.
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)