Conversation
…cker-builds into toulligqc-2.8.3
|
Does this warning matter? |
|
Otherwise, test seems to work |
|
This looks good to me, I just need to look up info about that warning to see if it's actually concerning. |
|
Agreed. I just don't know exactly what that means |
|
It looks like there's a new version now that fixes these warnings. I vote we upgrade this PR to the latest version. |
|
Okay sounds good. I will work on it now. |
|
Alright, I updated everything to 2.8.4 and my test build worked fine. I am curious to see if this update fixes the issue: |
erinyoung
left a comment
There was a problem hiding this comment.
Thank you for
- changing the filepath
- updating the hyperlink in the main README
|
The warning is still there, but I vote it's likely a small issue |
|
Thank you for putting this together! The status of the deployment can be found here : https://github.com/StaPH-B/docker-builds/actions/runs/23013590481 |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)Description
This PR is for toulligqc update to 2.8.3
Diff output
Test Build