Conversation
|
@erinyoung, if you still get the error, we can try removing git as well. |
|
plasmidfinder uses git at runtime, so we can't remove it. I've tried adding the directory as a safe directory, but then I get a |
|
@erinyoung, could you check it again with the latest changes? |
|
Works for me! Also, tests work in GA actions. |
|
Thank you for working on this! |
|
Future note: |
erinyoung
left a comment
There was a problem hiding this comment.
I have no changes to recommend. Let's get this merged and deployed.
|
Thank you so much for getting this together! The deploy link can be found here : https://github.com/StaPH-B/docker-builds/actions/runs/23009692166 |
There is a new version. Hopefully resolves #1585
Removed
.gitfiles after db installation.diff:
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)