Conversation
…implot.py is linked to /usr/local/bin for python path access.
… new tool, simplot-cl, version 1.0.3
| RUN micromamba install --name base -f /opt/simplot-cl-${SIMPLOT_CL_VER}/environment.yml -y && \ | ||
| micromamba clean -a -f -y && \ | ||
| mkdir /data | ||
|
|
There was a problem hiding this comment.
From https://github.com/hodcroftlab/simplot-cl/blob/main/environment.yml, it looks like the micromamba environment is very simple. It looks like it just consists of python packages and mafft. This image would be more stable and smaller without micromamba.
Could you try using the ubuntu:noble base?
There was a problem hiding this comment.
Sure, I'll give it a try, and I'll let you know if I run into any issues.
There was a problem hiding this comment.
I updated the base to python 3.13.12-slim. File size went from 2.07 GB to 643.58 MB. Ubuntu noble was giving me some issues with pip.
…buntu:noble and using pip. Should be lighter than micromamba.
|
Tests worked |
Updated README.md to include additional tools and example usage.
|
This looks good. I adjusted the tool-specific README
|
erinyoung
left a comment
There was a problem hiding this comment.
I have no changes to recommend.
Thank you for putting this together!
|
The status of the deployment can be found here : https://github.com/StaPH-B/docker-builds/actions/runs/23865101657 Since this is a new tool, it was appear as a private repo on quay. Hopefully I remember on my own to switch it to public once deployed there, but please remind me to do so if I have forgotten. |
Pull Request (PR) checklist:
docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15)docker-builds/build-files/spades/3.12.0/Dockerfile)build-files/shigatyper/2.0.1/test.sh)docker-builds/build-files/spades/3.12.0/README.md)This pull request is for a new tool, simplot-cl version 1.0.3. It includes a micromamba based dockerfile with needed dependencies for the main executable, simplot.py to work appropriately. The README.md for v1.0.3. is longer than 30 lines. I found it useful to include formats of files that could be passed as arguments, and having the arguments themselves as well as descriptions of the overall steps and outputs were noted for ease of access. Appropriate details / dropdowns have been made to condense the rendered space.