Skip to content

Conversation

@ryoppippi
Copy link
Member

@ryoppippi ryoppippi commented Dec 17, 2025

Summary by cubic

Add automated typo checking (US English) and split CI into parallel jobs to catch spelling errors early and speed up pipelines. Also standardized spelling across docs, examples, tests, and internal code.

  • CI/Tooling

    • Added typos job to GitHub Actions and a pre-push lefthook check.
    • Introduced typos.toml (en-us) with common ignores; excluded CHANGELOG.md and added to oxlint ignore.
    • Updated flake.nix to include typos, typos-lsp, and similarity.
    • Reworked CI into separate typos, lint, build-and-test, coverage jobs; coverage runs on main and deploy depends on coverage.
  • Refactors

    • Renamed normaliseHeaders to normalizeHeaders and updated imports/tests.
    • Fixed spelling in comments and messages (initialize, serialize, behavior, optimized/favor).
    • No runtime behavior changes.

Written for commit c437ee3. Summary will update automatically on new commits.

@ryoppippi ryoppippi requested a review from a team as a code owner December 17, 2025 14:49
Copilot AI review requested due to automatic review settings December 17, 2025 14:49
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

npm i https://pkg.pr.new/StackOneHQ/stackone-ai-node/@stackone/ai@254

commit: c437ee3

- Add typos check to pre-push hook to catch spelling errors before pushing
- Explicitly specify typos.toml configuration file
- Runs after staged changes but before knip linter
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds automated typo checking to the codebase using the typos tool, standardizing spelling from British English to American English conventions throughout the project.

  • Introduces typo checking via the typos tool with configuration in typos.toml
  • Standardizes spelling: "normalise" → "normalize", "initialise" → "initialize", "serialisation" → "serialization", "behaviour" → "behavior", "optimised" → "optimized", "favour" → "favor"
  • Integrates typo checking into CI pipeline and pre-push git hooks

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
typos.toml Adds configuration for the typos checker with US English locale and file exclusions
lefthook.yaml Adds typo checking as a pre-push git hook
flake.nix Adds typos and typos-lsp packages to the development environment
.github/workflows/ci.yaml Restructures CI jobs and adds dedicated typo checking job
src/toolsets.ts Renames normaliseHeaders to normalizeHeaders and updates comment spelling
src/toolsets.test.ts Updates test descriptions and comments from British to American English
src/requestBuilder.ts Updates comment spelling from "serialisation" to "serialization"
src/requestBuilder.test.ts Updates comment spelling from "behaviour" to "behavior" and "serialisation" to "serialization"
src/headers.ts Renames function and updates JSDoc from British to American English
src/headers.test.ts Updates all function calls and test descriptions to use American English
src/consts.ts Updates comment spelling from British to American English
examples/*.ts Updates comments from "Initialise" to "Initialize" across all example files
README.md Updates comment in code example from "Initialise" to "Initialize"
CHANGELOG.md Reformats bullet lists and corrects spelling inconsistencies in historical entries

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 23 files

Add CHANGELOG.md to oxlint ignorePatterns to prevent linting errors.
The changelog is auto-generated and should not be linted alongside
application code. It was already excluded from oxfmt.
Revert changelog formatting from dash bullets to asterisk bullets,
and restore blank lines after section headers. This aligns with the
canonical format maintained on the main branch.
@ryoppippi ryoppippi enabled auto-merge (squash) December 17, 2025 18:33
Copy link

@StuBehan StuBehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryoppippi ryoppippi merged commit f9928a4 into main Dec 17, 2025
16 checks passed
@ryoppippi ryoppippi deleted the another-nix branch December 17, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants